Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(renterd): remove allowance #808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(renterd): remove allowance #808

wants to merge 1 commit into from

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Nov 5, 2024 •
edited
Loading

renterd

  • The allowance concept was removed.
  • The allowance fitting and price fitting features were removed.
  • The configuration page has a new spending estimate widget that includes an option to rebalance prices within the current estimate.
  • All unit and e2e tests were updated and are passing.

renterd libs

  • Allowance was removed from autopilot contracts config API.
  • The autopilots key was removed from the pinned settings API.

design system

  • SiacoinField border is no longer blue in readOnly state.
  • SiacoinField now has a unitsFiatPostfix prop.

Screenshot 2024-11-08 at 9.38.51 AM.png

@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:52pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:52pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:52pm
hostd ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:52pm
website ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:52pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 392c21d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@siafoundation/design-system Minor
@siafoundation/renterd-types Minor
renterd Minor
@siafoundation/renterd-js Patch
@siafoundation/renterd-react Patch
@siafoundation/clusterd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Nov 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch 2 times, most recently from ffb69db to ecb4eb7 Compare November 7, 2024 20:53
@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch from ecb4eb7 to 6e45e0d Compare November 8, 2024 14:33
@alexfreska alexfreska marked this pull request as ready for review November 8, 2024 16:22
@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch from 6e45e0d to d9b3ceb Compare November 8, 2024 16:27
@alexfreska alexfreska mentioned this pull request Nov 8, 2024
Open
@alexfreska alexfreska mentioned this pull request Nov 8, 2024
Open
@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch from d9b3ceb to 564afe8 Compare November 8, 2024 20:29
@alexfreska alexfreska changed the base branch from main to chore_upgrade_cluster November 8, 2024 20:29
This was referenced Nov 8, 2024
Merged
Open
@alexfreska alexfreska changed the base branch from chore_upgrade_cluster to graphite-base/808 November 8, 2024 20:45
@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch 2 times, most recently from 90c2df9 to 392c21d Compare November 8, 2024 20:45
@alexfreska alexfreska changed the base branch from graphite-base/808 to main November 8, 2024 20:45
@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch from 392c21d to c2ca57b Compare November 8, 2024 20:46
@alexfreska alexfreska force-pushed the refactor_renterd_remove_allowance branch from c2ca57b to 392c21d Compare November 12, 2024 16:49
peterjan
peterjan approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 tough to review though 😅 (for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telestrial telestrial telestrial approved these changes

@peterjan peterjan peterjan approved these changes

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfreska @peterjan @telestrial